Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved MIDI files have excess duration #4

Closed
1j01 opened this issue Jul 11, 2019 · 1 comment
Closed

Saved MIDI files have excess duration #4

1j01 opened this issue Jul 11, 2019 · 1 comment
Labels
bug

Comments

@1j01
Copy link
Owner

1j01 commented Jul 11, 2019

I try to calculate the duration that the MIDI file should be, included as a delta of an event of type MIDIEvents.EVENT_META_END_OF_TRACK in the "conductor track".
I could try and fix this and figure out what's wrong with the math, but I might be able to just get rid of this entirely, I'm not sure it's needed.
I also might be able to calculate this more easily by just totalling up the deltas of the events...
Looks like it should just need / ms_per_tick tho?
(assuming rounding errors don't come into play at these time scales?)
@1j01 1j01 added the bug label Jul 11, 2019
@1j01
Copy link
Owner Author

1j01 commented May 4, 2022

I believe this is fixed... in 1fcc680

@1j01 1j01 closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1j01