Port additional effects for the Razer Kraken Kitty from openrazer #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1kc
approved these changes
Aug 23, 2021
| razer_send_payload(usb_dev, &report); | ||
| break; | ||
| } | ||
| break; |
There was a problem hiding this comment.
Thanks! I couldn't quite work out which conventions to follow - the ones elsewhere in razerheadphone, the ones from the file I copied this from (razerkbd), or the ones in the openrazer source I was porting.
Also worth noting that pre this, Razer MacOS would show a Spectrum option for the Razer Kraken Kitty, that when selected did nothing but showed no error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "Starlight", "Wave", and "Spectrum" effects for the Razer Kraken Kitty Edition.
Ported from @999eagle's addition to openrazer.