Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orochi V2 Support #29

Merged
merged 9 commits into from
Mar 13, 2022
Merged

Orochi V2 Support #29

merged 9 commits into from
Mar 13, 2022

Conversation

WrathofthePast
Copy link
Contributor

Adds support for both Bluetooth and Receiver connections

Note that this PR is dependent on #28; hence, the many commits and changes... merging that PR before this one will reduce the changes to 0 deletions, 3 files changed, and 14 additions.

DPI Stage support was excluded as librazermacos does not yet support the feature. I'm working on it though :)

Seems the PR from the front didn't make the update to the DeathAdder Essential 2021, so that's included in this.
For `is_charging` & `get_battery`, the Basilisk Ultimate had the wrong transaction id.
@WrathofthePast WrathofthePast changed the title Orochi V2 support Orochi V2 Support Feb 24, 2022
WrathofthePast added a commit to WrathofthePast/razer-macos that referenced this pull request Feb 24, 2022
Adds support for both bluetooth and receiver connections

Accompanying PR: 1kc/librazermacos#29

Due 1kc#558, I'm currently unable to provide a test build; however, anyone who wishes to test can build it.
@edualm
Copy link
Collaborator

edualm commented Feb 25, 2022

How would bluetooth work, considering this is an USB driver? Just curious!

I've merged the other PR, I think you need to rebase this one now.

Adds support for both Bluetooth and Receiver connections

DPI Stage support was excluded as librazermacos does not yet support the feature. I'm working on it though :)
@WrathofthePast
Copy link
Contributor Author

How would bluetooth work, considering this is an USB driver? Just curious!

openrazer has it working. I'm having it tested at issue 1kc/razer-macos#532. I might need to add read support for device idle time and low battery threshold. In terms of the backend, those are simply more parody improvements. The frontend will be a bit more work to integrate it into the UI. I'm also working on adding support for DPI Stages now that openrazer has added that functionality.

I've merged the other PR, I think you need to rebase this one now.

I rebased it. All of the conflicts are resolved and there are no more duplicate changes.

@1kc 1kc merged commit da15733 into 1kc:master Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants