New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi gpio input module #278

Merged
merged 4 commits into from Oct 29, 2018

Conversation

Projects
2 participants
@McGr3g0r
Copy link
Contributor

McGr3g0r commented Oct 1, 2018

This module uses up to 4 gpio pins and creates keycode from bits combination, there is 5th gpio pin used as latch signal - for example it can be used with ev1527 code receiver.

My OpenMQTTGateway in 3d printed case:

https://photos.app.goo.gl/unCdrHzDNx1J68cm6

@1technophile
Copy link
Owner

1technophile left a comment

Hello,

Thanks for this PR, codacy detected that the hex variable declaration can be moved to a reduced scope.
Could you move
char hex[3];
to line 64

@1technophile 1technophile added this to the V0.9 milestone Oct 3, 2018

@1technophile 1technophile merged commit c2e5595 into 1technophile:master Oct 29, 2018

1 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@1technophile

This comment has been minimized.

Copy link
Owner

1technophile commented Oct 30, 2018

@McGr3g0r Hello, thanks for this PR,
would you be interested in adding a wiki page describing your setup and another one about how to use it?

@1technophile 1technophile added this to Done in V0.9 Oct 30, 2018

1technophile added a commit that referenced this pull request Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment