-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rfe] combine register and post register #74
Comments
I do not recall other than it might have been an attempt to share common code between rhsm hosts and non-rhsm hosts. In reality, we should probably leverage the subscription bits in openshift-ansible and use the repos variable for non-rhsm. |
There are subscription bits in openshift-ansible now? |
@thoraxe The original code was contributed by Amadeus and modified by @codificat, but I'm not sure I want to tackle modifying it to update for 3.1 (and future versions) quite yet... Haven't put in enough thought on how to properly do it yet. For now, I think keeping the demo-ansible registration bits separate is a good idea. |
That's fine. What about combining the sub and repo-based activities into one playbook though? |
Already done in my PR. Stuck on getting the registration stuff sorted out
|
Closing now that #75 has merged |
Does anyone remember/recall why we have separated register_hosts and post_register?
Especially if we're doing these in serial, it might make sense to do them all in one playbook. It can make big environments take quite a long time.
The text was updated successfully, but these errors were encountered: