Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rfe] combine register and post register #74

Closed
thoraxe opened this issue Dec 16, 2015 · 6 comments
Closed

[rfe] combine register and post register #74

thoraxe opened this issue Dec 16, 2015 · 6 comments

Comments

@thoraxe
Copy link
Contributor

thoraxe commented Dec 16, 2015

Does anyone remember/recall why we have separated register_hosts and post_register?

Especially if we're doing these in serial, it might make sense to do them all in one playbook. It can make big environments take quite a long time.

@detiber
Copy link
Contributor

detiber commented Dec 17, 2015

I do not recall other than it might have been an attempt to share common code between rhsm hosts and non-rhsm hosts.

In reality, we should probably leverage the subscription bits in openshift-ansible and use the repos variable for non-rhsm.

@thoraxe
Copy link
Contributor Author

thoraxe commented Dec 17, 2015

There are subscription bits in openshift-ansible now?

@detiber
Copy link
Contributor

detiber commented Dec 21, 2015

@thoraxe The original code was contributed by Amadeus and modified by @codificat, but I'm not sure I want to tackle modifying it to update for 3.1 (and future versions) quite yet... Haven't put in enough thought on how to properly do it yet.

For now, I think keeping the demo-ansible registration bits separate is a good idea.

@thoraxe
Copy link
Contributor Author

thoraxe commented Dec 21, 2015

That's fine. What about combining the sub and repo-based activities into one playbook though?

@detiber
Copy link
Contributor

detiber commented Dec 22, 2015

Already done in my PR. Stuck on getting the registration stuff sorted out
right now (skipping re-reg on subsequent runs)
On Dec 21, 2015 5:16 PM, "Erik M Jacobs" notifications@github.com wrote:

That's fine. What about combining the sub and repo-based activities into
one playbook though?


Reply to this email directly or view it on GitHub
#74 (comment)
.

@detiber
Copy link
Contributor

detiber commented Dec 23, 2015

Closing now that #75 has merged

@detiber detiber closed this as completed Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants