SEC-1431-Lintly-parser-for-gitleaks

[nandusekarv10]

No description provided.

[scriptsrc]

Requesting a couple minor changes. It might be a good idea to run some combo of pylint/flake8/black to lint and format consistently.

[sarahc23]

Please also edit the commit message (I dunno, may require a rebase and force push?) to be something more descriptive of the entire commit. (Using something similar to the title of this PR is fine, although it's practice around here to put the ticket number before the rest of the message -- SEC-1431 Added lintly parser for gitleaks. or something like that.)

[sarahc23]

I still think it's confusing for a future maintainer of this project to use a false positive test case here.

I'm assuming you got this from running gitleaks on the current file (gitleaks.json), which is a FP, because there's no actual private key material here.

If someone had checked in a real key, the line would start with just -----BEGIN PRIVATE KEY-----. (In other words, this entire line should just be

         "line": "-----BEGIN PRIVATE KEY-----",

).

[nandusekarv10]

So you want me to change this line to -----BEGIN PRIVATE KEY----- or add extra file with private key and then write test case around that?

[sarahc23]

Just change the line. I don't think you need to add extra tests or make any changes to the existing test.

[sarahc23]

lol you didn't need to put dashes or hyphens in a commit message (spaces are okay! commit messages are meant for human consumption), but this is fine.