4.3.caller id numbers #6655
Open
4.3.caller id numbers #6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RegexList -> | ||
| try | ||
| RE = "^\\^\\\\\\+\\?(.*)\\\.\\+\\$", | ||
| <<":", ColonList/binary>> = |
There was a problem hiding this comment.
I would look at using kz_binary:join([convert_regex_to_caller_id()], <<":">>) instead of the fold, personally.
| @@ -68,7 +68,7 @@ caller_id_numbers(Doc) -> | |||
|
|
|||
| -spec caller_id_numbers(doc(), Default) -> binary() | Default. | |||
| caller_id_numbers(Doc, Default) -> | |||
| kz_json:get_binary_value([<<"caller_id_numbers">>], Doc, Default). | |||
| kz_json:get_list_value([<<"caller_id_numbers">>], Doc, Default). | |||
There was a problem hiding this comment.
Spec needs updating if you're fetching a list here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting a rate for an inbound call with caller_id_numbers filter was failing here:
kazoo/applications/hotornot/src/hon_util.erl
Line 258 in 1fbde96
kzd_rates:caller_id_numbers(Rate, [<<".">>]) should be returning the list of regexes but it was returning a binary instead.
Also fixed up the CSV import/export so now the export CSV has the same format as the import CSV.
When we exported a ratedeck the caller_id_numbers in the CSV were in the internal regex format and so if that file was then imported back the field was corrupted and the filter no longer worked.
The CSV format of the caller_id_numbers should be ':' seperated list of prefixes in both import and export files