Fix dismiss issues #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from breaking the back button behaviour
|
can you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes some some issues that I found while using a sequence.
The main one involved just tapping the spotlight view multiple times. Because
dismisswas called for each tap, the animation spazzed out and theonUserClickedcallback was triggered multiple times, breaking the sequence badly.Another issue could occur when focus was lost between views of a sequence. Since
requestFocus()was only called before the view was visible, it didn't actually seem to do anything. By calling it right after the view is set visible, focus is actually granted, and the back button functions properly.