Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MemoryFlare #215

Merged
merged 3 commits into from
Jan 20, 2020
Merged

Add MemoryFlare #215

merged 3 commits into from
Jan 20, 2020

Conversation

yuwen-yan
Copy link
Collaborator

@yuwen-yan yuwen-yan commented Dec 27, 2019

PR to implement #202

@luigi-rosso
Copy link
Contributor

This looks great! I just had a small nitpick with a comment which made me wonder about the intention of a constructor but the memory functionality is great. We can clean up the comment/constructor later if you want to get this merged.

@yuwen-yan
Copy link
Collaborator Author

@luigi-rosso kindly ping

Copy link
Contributor

@luigi-rosso luigi-rosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, sorry for the delay here

@luigi-rosso luigi-rosso merged commit ce8528f into master Jan 20, 2020
@luigi-rosso
Copy link
Contributor

We'll work on getting a release with this to pub.dev tomorrow.

@ogiogi93
Copy link

ogiogi93 commented Feb 8, 2020

@luigi-rosso When will this be released to pub.dev? 👀
I'm waiting for it.

@umberto-sonnino umberto-sonnino deleted the ybbaigo-asset-provider branch July 11, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants