Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --skip-tags evaluation logic #120

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Fix --skip-tags evaluation logic #120

merged 2 commits into from
Mar 19, 2020

Conversation

seleznev
Copy link
Collaborator

Closes #119.

Previous version of Renderer._evaluate_tags() didn't work well because of:

>>> tags=set()
>>> only_tags=tags
>>> tags.isdisjoint(only_tags)
True

@seleznev seleznev added the bug Something isn't working label Mar 18, 2020
@seleznev seleznev self-assigned this Mar 18, 2020
furiousassault
furiousassault approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@furiousassault furiousassault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seleznev seleznev merged commit 3700f5b into master Mar 19, 2020
@seleznev seleznev mentioned this pull request Mar 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furiousassault furiousassault furiousassault approved these changes

@rvadim rvadim rvadim approved these changes

@dcleric dcleric Awaiting requested review from dcleric

@dekhtyarev dekhtyarev Awaiting requested review from dekhtyarev

Assignees

@seleznev seleznev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skip-tags does not work
3 participants
@seleznev @rvadim @furiousassault