Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use replace() API call for Custom Resources #136

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Use replace() API call for Custom Resources #136

merged 1 commit into from
Mar 1, 2021

Conversation

seleznev
Copy link
Collaborator

Motivation:

  • patch() API call doesn't work well when you delete something (annotations, for ex.) from templates (deleted parts still presents in the cluster after patch()).
  • For most another resource types we use replace() already.

@seleznev seleznev added the bug Something isn't working label Feb 25, 2021
@seleznev seleznev self-assigned this Feb 25, 2021
Copy link
Collaborator

@furiousassault furiousassault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dekhtyarev
Copy link
Collaborator

lgtm

Copy link
Collaborator

@rvadim rvadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seleznev seleznev merged commit 2df08f4 into master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants