Fix shared directory ownership and enable w+r on it #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first piece of this commit is executing on the workaround described in [1] for the missing ownership on the _shared directory [2]. The second pieces essentially disable the ReadOnly attribute on the mounted _shared directory so it is writable by everyone (admin and users)[3]. [1] #440 [2] #810 (comment) [3] #810 (comment)
10 tasks
|
As you can see from the linked comment, I have successfully tested this on openscapes |
damianavila
requested review from
consideRatio,
yuvipanda and
GeorgianaElena
yuvipanda
approved these changes
Nov 14, 2021
consideRatio
approved these changes
Nov 14, 2021
choldgraf
approved these changes
Nov 14, 2021
There was a problem hiding this comment.
+1 since they asked for it, we should ask them how they're using this functionality, as this is a new request that we haven't tried before!
Thanks @damianavila for tackling this on a weekend 🙏
|
The openscapes folks re-confirmed they want the writable shared space so going to merge this one now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first piece of this commit is executing on the workaround described
in [1] for the missing ownership on the _shared directory [2].
The second pieces essentially disable the ReadOnly attribute on the
mounted _shared directory so it is writable by everyone (admin and
users)[3].
[1] #440
[2] #810 (comment)
[3] #810 (comment)