Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to enable CILogon for a hub #941

Merged
merged 8 commits into from
Jan 27, 2022

Conversation

GeorgianaElena
Copy link
Member

Fixes #315

I added a commit that enables CILogon for the staging hub, just as an example. I deployed the change manually however if anybody wants to test tat, but will be overwritten when a new deploy from the CI will happen.

On the staging hub right now we have:

  • staff 2i2c emails are admins
  • anyone with an @2i2c.org and @berkeley.edu address is allowed to login the hub.

Copy link
Contributor

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 50 to 54
# this will be replaced with the actual list of
# staff google ids by the deployer script
admin_users: &staging_admins
- <staff_google_ids>
- colliand@gmail.com
admin_users: *staging_users
username_pattern: '^(.+@2i2c\.org|.+@berkeley\.edu|deployment-service-check)$'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should test/show off the CILogon feature on the staging hub or it's best if I deploy a new hub?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be OK to have it on staging, @2i2c-org/tech-team WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually feel like we should have a dedicated hub to show off these kinds of things - the staging hub is meant for staging and trying out changes as part of our deployment pipeline, so I feel like we should reserve it for those purposes rather than showing off new features and such. What if we deployed a hub like demo.2i2c.cloud that was for demonstration purposes, and where we could change the config etc without worrying that it'll affect our other deployments?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we used the cloudbank demo hub? I don't think that's used right now

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice start! I added a few suggestions and comments in there, let me know what you think!

docs/howto/configure/auth-management.md Outdated Show resolved Hide resolved
docs/howto/configure/auth-management.md Outdated Show resolved Hide resolved
docs/howto/configure/auth-management.md Outdated Show resolved Hide resolved
docs/howto/configure/auth-management.md Show resolved Hide resolved
docs/howto/configure/auth-management.md Outdated Show resolved Hide resolved
docs/howto/configure/auth-management.md Outdated Show resolved Hide resolved
docs/howto/configure/auth-management.md Show resolved Hide resolved
docs/howto/configure/auth-management.md Outdated Show resolved Hide resolved
GeorgianaElena and others added 7 commits January 27, 2022 12:21
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Rephrase to make the note about user_id more understandable

Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
@GeorgianaElena
Copy link
Member Author

Thanks for the feedback @damianavila and @choldgraf! I decided to drop the commit that enabled CILogon on the staging hub and instead let this PR be just about the docs so we don't block on that.

The plan is to open a follow-up PR to deploy a new 2i2c demo hub to show off the CILogon auth instead and we can discuss more there. Hope that's ok. I will go ahead and merge this now since I have an appoval 🚀 Thank you!

@GeorgianaElena GeorgianaElena merged commit f246a7e into 2i2c-org:master Jan 27, 2022
@GeorgianaElena GeorgianaElena deleted the document-cilogon branch January 27, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable authentication via CILogon
3 participants