Avoid getting request body as much as possible in the handler. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
k1LoW
commented
Jun 14, 2024
| ww := w.(io.Writer) | ||
| buf := getCopyBuf() | ||
| defer putCopyBuf(buf) | ||
| if _, err := io.CopyBuffer(ww, res.Body, buf); err != nil { |
There was a problem hiding this comment.
Use io.CopyBuffer instead of io.ReadAll
k1LoW
commented
Jun 14, 2024
rc.go
Outdated
Comment on lines
193
to
211
| ok, expires := m.cacher.Storable(reqc, res, now) | ||
| if !ok { | ||
| m.logger.Debug("cache not storable", slog.String("host", reqc.Host), slog.String("method", reqc.Method), slog.String("url", reqc.URL.String()), slog.Any("headers", m.maskHeader(reqc.Header)), slog.Int("status", res.StatusCode), slog.Any("response_headers", m.maskHeader(res.Header))) | ||
| return res, nil | ||
| } | ||
|
|
||
| res2 := rec.Result() | ||
| go func() { | ||
| // Store response as cache | ||
| if err := m.cacher.Store(reqc, res2, expires); err != nil { | ||
| m.logger.Error("failed to store cache", slog.String("error", err.Error()), slog.String("host", reqc.Host), slog.String("method", reqc.Method), slog.String("url", reqc.URL.String()), slog.Any("headers", m.maskHeader(reqc.Header)), slog.Int("status", res.StatusCode)) | ||
| } | ||
| m.logger.Debug("cache stored", slog.String("host", reqc.Host), slog.String("method", reqc.Method), slog.String("url", reqc.URL.String()), slog.Any("headers", m.maskHeader(reqc.Header)), slog.Int("status", res.StatusCode)) | ||
| }() | ||
|
|
||
| return res, nil | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Determines storable at the time the response is received from upstream.
k1LoW
commented
Jun 14, 2024
Comment on lines
+194
to
+206
| go func() { | ||
| ok, expires := m.cacher.Storable(reqc, resc, now) | ||
| if !ok { | ||
| m.logger.Debug("cache not storable", slog.String("host", reqc.Host), slog.String("method", reqc.Method), slog.String("url", reqc.URL.String()), slog.Any("headers", m.maskHeader(reqc.Header)), slog.Int("status", res.StatusCode), slog.Any("response_headers", m.maskHeader(resc.Header))) | ||
| return | ||
| } | ||
|
|
||
| // Store response as cache | ||
| if err := m.cacher.Store(reqc, resc, expires); err != nil { | ||
| m.logger.Error("failed to store cache", slog.String("error", err.Error()), slog.String("host", reqc.Host), slog.String("method", reqc.Method), slog.String("url", reqc.URL.String()), slog.Any("headers", m.maskHeader(reqc.Header)), slog.Int("status", resc.StatusCode)) | ||
| } | ||
| m.logger.Debug("cache stored", slog.String("host", reqc.Host), slog.String("method", reqc.Method), slog.String("url", reqc.URL.String()), slog.Any("headers", m.maskHeader(reqc.Header)), slog.Int("status", resc.StatusCode)) | ||
| }() |
There was a problem hiding this comment.
Use goroutine to avoid blocking due to the storing process.
Code Metrics Report
Details | | main (1439b7d) | #81 (90bdb04) | +/- |
|---------------------|----------------|---------------|-------|
+ | Coverage | 61.2% | 61.9% | +0.7% |
| Files | 7 | 8 | +1 |
| Lines | 446 | 454 | +8 |
+ | Covered | 273 | 281 | +8 |
- | Code to Test Ratio | 1:2.2 | 1:2.2 | -0.0 |
| Code | 758 | 775 | +17 |
| Test | 1685 | 1685 | 0 |
| Test Execution Time | 40s | 40s | 0s |Code coverage of files in pull request scope (76.2% → 77.9%)
Reported by octocov |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, avoid
io.ReadAll