Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DiskCacheOption signature #51

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Change DiskCacheOption signature #51

merged 2 commits into from
Mar 4, 2024

Conversation

k1LoW
Copy link
Member

@k1LoW k1LoW commented Mar 4, 2024

SSIA.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Code Metrics Report

main (705bd79) #51 (0c7f381) +/-
Coverage 80.3% 79.2% -1.1%
Code to Test Ratio 1:2.1 1:2.0 -0.0
Details
  |                    | main (705bd79) | #51 (0c7f381) |  +/-  |
  |--------------------|----------------|---------------|-------|
- | Coverage           |          80.3% |         79.2% | -1.1% |
  |   Files            |              2 |             2 |     0 |
  |   Lines            |            203 |           212 |    +9 |
+ |   Covered          |            163 |           168 |    +5 |
- | Code to Test Ratio |          1:2.1 |         1:2.0 |  -0.0 |
  |   Code             |            445 |           456 |   +11 |
  |   Test             |            922 |           922 |     0 |

Code coverage of files in pull request scope (81.3% → 79.9%)

Files Coverage +/-
diskcache.go 79.9% -1.5%

Reported by octocov

Copy link
Contributor

github-actions bot commented Mar 4, 2024

BenchmarkDiscCache1MBBody-4

main (-) #51 (0c7f381) +/-
Number of iterations 1000 1000 0
Nanoseconds per iteration 1395939 ns/op 1411727 ns/op 15788 ns/op
Bytes allocated per iteration 7406673 B/op 7406946 B/op 273 B/op
Allocs per iteration 536 allocs/op 538 allocs/op 2 allocs/op
Metadata
main (-) #51 (0c7f381)
goos linux linux
goarch amd64 amd64
pkg github.com/2manymws/rcutil github.com/2manymws/rcutil
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkEncodeDecode1MBBody-4

main (-) #51 (0c7f381) +/-
Number of iterations 1000 1000 0
Nanoseconds per iteration 5133102 ns/op 4779862 ns/op -353240 ns/op
Bytes allocated per iteration 8425070 B/op 8425060 B/op -10 B/op
Allocs per iteration 332 allocs/op 331 allocs/op -1 allocs/op
Metadata
main (-) #51 (0c7f381)
goos linux linux
goarch amd64 amd64
pkg github.com/2manymws/rcutil github.com/2manymws/rcutil
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkNGINXCache1MBBody-4

main (-) #51 (0c7f381) +/-
Number of iterations 1000 1000 0
Nanoseconds per iteration 323487 ns/op 327481 ns/op 3994 ns/op
Bytes allocated per iteration 14233 B/op 14224 B/op -9 B/op
Allocs per iteration 90 allocs/op 90 allocs/op 0 allocs/op
Metadata
main (-) #51 (0c7f381)
goos linux linux
goarch amd64 amd64
pkg github.com/2manymws/rcutil github.com/2manymws/rcutil
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

@k1LoW k1LoW merged commit 70a88e6 into main Mar 4, 2024
5 of 6 checks passed
@k1LoW k1LoW deleted the fix-option-sig branch March 4, 2024 06:28
@github-actions github-actions bot mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant