Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying environment variables when generating a pod template spec #37

Closed
whitlockjc opened this issue Jun 24, 2016 · 1 comment
Assignees
Milestone

Comments

@whitlockjc
Copy link
Contributor

whitlockjc commented Jun 24, 2016

Many applications use environment variables for runtime configuration and without the ability to specify environment variables when generating the PTS, generating a PTS is not very useful.

@whitlockjc whitlockjc added this to the beta milestone Jul 5, 2016
@noahdietz
Copy link
Contributor

Environment variables will be specified by client at image build time and baked into the Dockerfile, pre-build, thus they are built into the image pulled by the PTS.

For documentation:

  • these env variables should not contain sensitive information (i.e. secrets, tokens, etc) as they are insecure.
  • PTS ("deployment-time") specified env variables will override duplicates specified in the Dockerfile ("build-time")

The other option was using the PTS URL as "storage" and encoding these env variables into the query string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants