Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review application details payload #89

Open
whitlockjc opened this issue Feb 8, 2017 · 3 comments
Open

Review application details payload #89

whitlockjc opened this issue Feb 8, 2017 · 3 comments

Comments

@whitlockjc
Copy link
Contributor

When reviewing shipyardctl we realized that it would be nice to have more information about an image to display to the user.

@noahdietz
Copy link
Contributor

noahdietz commented Feb 8, 2017

I just realized, the Docker Engine API might give us some set of image details, but the ECR API may not provide that same set, same with the Registry API (which isn't exactly the same, and this is still being integrated with kiln as of rn). Just documenting the possibility, I don't have an example.

@noahdietz
Copy link
Contributor

noahdietz commented Feb 8, 2017

First example found:
GetImages(org, appName) with ECR will require an* additional API call of DescribeImages to get Created time

*the ecr.ListImages call is paged, so if more than X number of images in result, results will be divided into total/X pages and iterated over, each requiring a subsequent DescribeImages call

@noahdietz
Copy link
Contributor

noahdietz commented Feb 9, 2017

Similarly,
GetApplications(org) with ECR currently just returns the "repo" (aka application) name using its DescribeRepositories API...these results could be fed into the aforementioned GetImages(org, appName) API call but then we're stacking several ECR API calls.

This is not an argument against expanding the result details, just documenting the potential changes and their impact based on the current implementation.

@noahdietz noahdietz removed their assignment Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants