Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown on Docker Daemon Error #94

Open
AdamMagaluk opened this issue Feb 22, 2017 · 2 comments
Open

Shutdown on Docker Daemon Error #94

AdamMagaluk opened this issue Feb 22, 2017 · 2 comments

Comments

@AdamMagaluk
Copy link

Should we be shutting down with a Fatal error if Docker Daemon returns an error here: https://github.com/30x/kiln/blob/master/pkg/kiln/docker_repo.go#L262

I cam across this with trying to add an envVar and didn't set the data right.

curl --fail -v -H 'Authorization:Bearer $TOKEN' -H Host:api.shipyard.dev -F file=@./fixture/app.zip -F name=test-app -F envVar=SOME_VAR http://192.168.99.100:30555/organizations/adammagaluk1/apps

@noahdietz
Copy link
Contributor

Would replying with a 400 Bad Request be the right StatusCode? As well as the docker build error

@noahdietz
Copy link
Contributor

We might not know its a Bad Request issue, it could be something else that is kiln's fault, so maybe just 500 Internal Server Error?

@noahdietz noahdietz self-assigned this Feb 28, 2017
@noahdietz noahdietz removed their assignment Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants