-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove games/large examples to their own repositories #744
Comments
Flight is an "interesting" one, it's the only mode7 example, but it also uses the I guess racer would be on this list if it existed and shmup if there was a game in there... |
Obvious garbage like racer and shmup could probably be summarily deleted. It's not like the history isn't there if anyone wants to revive them to a new project... and it's not like either really has any useful content. Albeit shmup is a rather nice palette cycling demo under all the guff 😆 |
Has been moved to https://github.com/32blit/32blit-another-world for #744
Deleting things is fun: Daft-Freak@4f4f347. (I guess if you want a "racer", there are at least 3 games on BlitHub.) |
What if we did this: https://github.com/Daft-Freak/32blit-examples (stealing the idea from pico-sdk/examples) ... then made the SDK's actions pull that so we're build testing the same things. (and update the docs) |
Looks awesome; wondering if it makes sense to divide it into "examples" (or specific tech / API / technique) and "games" (which are more complete and not showcasing anything specific) |
Hmm, probably a good idea... Shouldn't be hard to recoganise things, that was just a quick |
That's a great idea, keeps the SDK lean and to the point without forgoing our "testing" Does this mean we'll end up with a 32blit-extras? 😆 |
Expect a PR with a lot of deletions then 😆 ... anyone feel like writing the README for 32blit-examples?
I think that's called |
So this completely breaks the .sln... my preferred solution (hah) is to delete it... any other suggestions? (I currently don't have a full VS install) Other smaller problems:
https://github.com/Daft-Freak/32blit-beta/tree/split-examples |
Actually maintaining the .sln is an eldritch horror, and I also lack a VS install. It has some utility to windows-based devs, though, easy access to profiling, debugging at least on a host PC. I'm kind of remiss to remove it altogether, but realise I'd be volunteering to fix it if I vote stay. I'm going to take it @ahnlak votes "delete it" 😆 4156d42 It doesn't really have many die-hard fans...
|
I have no memory of that commit, but certainly echo the sentiment 🤣 Given that VS plays nicely(?) with CMake these days, I'm inclined to say kill it with fire. |
I'm pretty sure at least debugging works with the "Open folder" thing. There was never really a way to use it with the boilerplate anyway. In the 70-ish repos I have for the bot, there are 5 with .vcxproj files (from the same user). So I don't think it was very widely used.
...
|
I looked into how many examples I need to write pithy descriptions of to make an example readme and died inside, if removing VS saves effort (it's probably going to make more work ugh) then I concur. I think Geometry, Ray Caster and Rainbow Ascent probably:
That, unfortunately, is my problem I think... As for PicoSystem Hardware test and 32blit Hardware test... not really sure about those. Sheesh I wonder why I never came back with some cover art. That wasn't even the year I got totally absorbed into writing Sprite Editor. |
Hardware test is really useful for bringing up new (or very old) hardware. It would be even more useful if there was a way to build it for internal flash without having to hack around the build files. Can this be done in an external repo? If not then I think it should stay in main. Maybe some of the functionality could even be merged into the firmware itself. |
I would offer to help with the comments / docs on those three but... I don't know how any of them work 🤣 I do keep wondering if there's a handful of simple, classic games "someone" could build in a fully commented, documented, tutorial-ified form (but that may be a 'future' job) |
I've deleted vs in the branch to fix the build fail for now. Building the examples is quite a large chunk of the build docs, ugh. (Writing is definitely not my thing...) Yeah, hardware-test is quite useful, I use it a lot for pico testing. Don't think Merging some of it into the firmware doesn't help me much due to how uh, device-specific the firmware is. (Maybe this will improve as part of my attempt to get full functionality on [some other device]...). Not saying that a "test mode" in the firmware isn't a good idea though. |
I started putting together an examples README, but I'm being pulled in all directions at the moment, so bear with me. I do wonder if the docs need a thorough overhaul and just to live in Do worry about change for change's sake, though, versus doing stuff to actively position this project for the new few years of development. |
It is nice to have docs located with the code. To avoid unnecessary CI, you can always detect which files are changed by a PR and only build docs. |
Wow, TIL that |
Maybe we need another issue for sorting out the docs 🤔 |
Hah, I've locked myself out of the settings for 32blit-examples 🤦 |
Fixed, I think! |
If we keep the hardware-tests here, where should they go? ("examples" doesn't really fit any more, and... naming things is hard). Also thinking of moving firmware/firmware-update under 32blit-stm32, as they're really tied to that platform... but that's another issue. |
"utilities", maybe? (which might be a good home for @Gadgetoid's sprite editor, too...) |
Went with that for now. The sprite editor is quite big so maybe not... |
"quite big" is a polite way to put that sprawling mess 😆 |
The following should move into their own GitHub repositories under the 32blit umbrella:
Anywhere this leaves a gap in coverage, a basic test example should be added.
We can probably also still build these examples and pull them in to the release .zip file, or append them as a "games.zip".
Or... y'know... direct people to Blithub!
The text was updated successfully, but these errors were encountered: