UP-431 - Adds product recommendations method #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uschischroder
force-pushed
the
UP-431-method-product-recommendations
branch
from
4a59a65
to
6002b0e
Compare
Drafter500
reviewed
Aug 26, 2020
| .join('&'); | ||
| } | ||
|
|
||
| export async function getProductRecommendations( |
Drafter500
reviewed
Aug 26, 2020
src/services/recommendations.ts
Outdated
| ): Promise<Result<BaseProduct, HttpError>> { | ||
| const inputParams = makeSearchParams(params); | ||
| try { | ||
| const recommendations = await get(`/recommendations${inputParams}`); |
There was a problem hiding this comment.
before search params string there should be ? sign
uschischroder
force-pushed
the
UP-431-method-product-recommendations
branch
from
fb55251
to
25a3f81
Compare
enjoythelive1
requested changes
Aug 28, 2020
src/services/api/methods.test.ts
Outdated
| import { get, post, put, patch } from './methods'; | ||
|
|
||
|
|
||
| const PRODUCTS_API = 'https://products.35up.com/'; |
There was a problem hiding this comment.
This should be stored in env
src/services/api/methods.ts
Outdated
| import { createMethod } from '@caseable/http-client'; | ||
|
|
||
|
|
||
| const BASE_URL = 'https://products.35up.com/'; |
There was a problem hiding this comment.
This should be in env
Drafter500
approved these changes
Aug 28, 2020
gustavoaz7
suggested changes
Aug 28, 2020
src/services/api/methods.test.ts
Outdated
| @@ -0,0 +1,44 @@ | |||
| import { expect } from 'chai'; | |||
There was a problem hiding this comment.
I guess this was already discussed in other admin panel PR that here we are basically testing createMethod which is a 3rd party library function.
So this test suit could be removed
@enjoythelive1 @Drafter500
src/services/recommendations-data.ts
Outdated
| @@ -0,0 +1,42 @@ | |||
| import { InputParameters, ProductRecommendations } from '../types'; | |||
|
|
|||
| export const getMockRecommendations = (params: InputParameters): ProductRecommendations => ({ | |||
There was a problem hiding this comment.
Suggested change
| export const getMockRecommendations = (params: InputParameters): ProductRecommendations => ({ | |
| export const getMockRecommendations = ( | |
| params: InputParameters, | |
| ): ProductRecommendations => ({ |
src/services/recommendations.ts
Outdated
| @@ -39,3 +42,14 @@ export function makeSearchParams(input: InputParameters): string { | |||
| .join('&'); | |||
| } | |||
|
|
|||
| export async function getProductRecommendations( | |||
| params: InputParameters, | |||
| ): Promise<Result<ProductRecommendations, HttpError>> { | |||
There was a problem hiding this comment.
Should we go for Result or RemoteData ?
There was a problem hiding this comment.
I incline for remote data
enjoythelive1
approved these changes
Aug 28, 2020
uschischroder
force-pushed
the
UP-431-method-product-recommendations
branch
from
c927bf6
to
0b1c138
Compare
enjoythelive1
approved these changes
Aug 28, 2020
Drafter500
approved these changes
Aug 31, 2020
gustavoaz7
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft: need the types from the previous PR.