Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Adds check to see if dictionary array passed to sqk_insertOrUpdate is valid #47

Closed
wants to merge 1 commit into from

Conversation

zilmarinen
Copy link
Member

Includes a check to see if dictionary array is valid before attempting to filter nil or empty array.

@blork
Copy link
Contributor

blork commented Jan 14, 2015

Hard to decide whether this belongs in or not. It's tempting to just allow the invalid value since it makes calling code nicer to read, but I feel like it should probably crash if called with nil, just as if an app would crash if you tried to insert nil into an array.

It's similar in a way, since in both you are attempting to insert data. The precedent is set by Foundation, so for now, not going to merge.

You could always make you're own method that wraps sqk_insertOrUpdate and does the check.

@blork blork closed this Jan 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants