Fix int64 overflow with recent ffmpeg #63
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFmpeg v3.3.4
gmf does not compile with the following error:
github.com/3d0c/gmf/codec.go:95: constant 9223372036854775808 overflows int64
In my version of ffmpeg this is defined as
./avutil.h:#define AV_NOPTS_VALUE ((int64_t)UINT64_C(0x8000000000000000))
Why the constant is defined as an uint64 literal which is cast to an (overflowing) int64 is beyond my comprehension, but since the code uses
C.AV_NOPTS_VALUE
the actual value produced here should not be important.