log the plugin loading NoClassDefFoundError

[yaozhihang]

Fix the issue
#285

[clausnagel]

Thanks, @yaozhihang. Couldn't we alternatively just log exceptions for those plugins that cannot be loaded (via something like addException) and load those plugins that can be loaded?

[clausnagel]

I suggest catching Throwable here

[yaozhihang]

done with 952a7fd

[yaozhihang]

Hm, i think not possible. The exception is thrown in the method hasNextService of the ServiceLoader and no plugin info is returned. You have ideas?

[clausnagel]

Hm, i think not possible. The exception is thrown in the method hasNextService of the ServiceLoader and no plugin info is returned. You have ideas?

I also tested the iterator interface of the ServiceLoader and unfortunately the error is already thrown in the hasNext instead of the next method. So I can confirm that it's not really possible to skip just those plugins with errors and load the others.

I nevertheless propose a small change. I think it would be better to use the exception handling of the PluginManager class. This way, the CLI fails on errors (default behaviour), while the error is shown in the console window when using the GUI.

proposal.patch

[yaozhihang]

Hm, i think not possible. The exception is thrown in the method hasNextService of the ServiceLoader and no plugin info is returned. You have ideas?

I also tested the iterator interface of the ServiceLoader and unfortunately the error is already thrown in the hasNext instead of the next method. So I can confirm that it's not really possible to skip just those plugins with errors and load the others.

I nevertheless propose a small change. I think it would be better to use the exception handling of the PluginManager class. This way, the CLI fails on errors (default behaviour), while the error is shown in the console window when using the GUI.

proposal.patch

thanks @clausnagel. The Proposal is in this commit d7ff2c3