Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring non-existent motion-corrected images in gCTF #45

Closed
bforsbe opened this issue Jul 6, 2016 · 4 comments
Closed

Ignoring non-existent motion-corrected images in gCTF #45

bforsbe opened this issue Jul 6, 2016 · 4 comments

Comments

@bforsbe
Copy link
Contributor

bforsbe commented Jul 6, 2016

Originally reported by: Mazbit (Bitbucket: Mazbit, GitHub: Unknown)


Hi guys,

I come across a tiny issue. My test data deliberately contains awful movies of broken ice, for which MOTIONCORR fails without producing a corrected image --> good!

Nevertheless, corrected_micrographs.star includes the non-existing images and produces an error with gCTF. Perhaps corrected_micrographs.star could be generated based on actual MOTIONCORR outputs.

Thanks
Mazdak


@bforsbe
Copy link
Contributor Author

bforsbe commented Jul 6, 2016

Original comment by Bjoern Forsberg (Bitbucket: bforsbe, GitHub: bforsbe):


Hi Mazdak,

So this is something which does not happen when you run MOTIONCORR without the use of RELION?

@bforsbe
Copy link
Contributor Author

bforsbe commented Jul 6, 2016

Original comment by Mazbit (Bitbucket: Mazbit, GitHub: Unknown):


Hi Bjoern,

if the inputs are really bad, MOTIONCORR won't spit out a corrected image with or without wrapper. It's a cheap way for reducing a dataset right at the beginning. But Gctf won't run and report an error if some of its inputs (ie corrected micrographs) are missing. Therefore, it could be better to create the micrographs_corrected.star file by reading in MOTIONCORR outputs.

cheers
Mazdak

@bforsbe
Copy link
Contributor Author

bforsbe commented Jul 6, 2016

Original comment by Bjoern Forsberg (Bitbucket: bforsbe, GitHub: bforsbe):


Ah, that clears it up. Your suggestion makes sense.

@biochem-fan
Copy link
Member

The current wrapper should handle this.

scheres pushed a commit that referenced this issue Oct 25, 2023
* stub packages for tilt-image exclusion GUI

* working prototype CLI

still todo:
- saving output
- add new deps

* add explicit metadata model

* added saving in separate thread and selection buttons

* fix imports in tsa programs

* formatting

* formatting

* fix refactoring bugs in fiducials cli

* gui -> gui_components

* start on integrating into relion gui...

* more relion gui

* fix packaging and move to pyproject.toml only build

* add console script for exclude tilt-images GUI to pyproject.toml config

* factor out a passive tilt-series viewer

* hide completions in viewer CLIs

* fix formatting error (runtime error: unrecognised job-type)

* Added exclude views to rln GUI (#48)

* data_models -> gui_data_models

* fix bug in output star file paths

* add tilt-series metadata example files

* metadata model tests and small refactor...

* few more simple tests

* better gui model test

* add test data

* fix import and small refactor

* add psygnal dep

* fix import

* fix bad refactor imports

* add signals for loose coupling between tilt series change and other widget behaviours

* recreate excluder widget using tilt-series browser

* add relion tilt image excluder

* correct ref to selected ts name

* bye bye metaclass

* remove old save function

* add save button label

* remove ref to old save func

* fix ref to tilt image list widget from browser

* fix visual style of widget

* fix deselection thing - GUI now back in working state

* mini doc for tilt image list

* almost working with factored out tilt-image selection widget

* fix bug in saving output which meant global data file was not saved

Co-authored-by: EuanPyle <euanpyle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants