Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL - Check that QGIS server is OK before opening a project #3142

Merged
merged 2 commits into from
Aug 9, 2022
Merged

ACL - Check that QGIS server is OK before opening a project #3142

merged 2 commits into from
Aug 9, 2022

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Aug 1, 2022 •
edited
Loading

  • Before opening a QGIS project, Lizmap is now checking that :
    • Lizmap QGIS server plugin is running with a minimum required version
    • QGIS server version is running with at least 3.10
    • These two versions are hardcoded in the source code and updated when a new version of Lizmap is released

Fix #2972 and linked to #2058

Funded by 3Liz

mdouchin
mdouchin requested changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things

lizmap/modules/admin/controllers/server_information.classic.php Outdated Show resolved Hide resolved
lizmap/modules/admin/controllers/server_information.classic.php Outdated Show resolved Hide resolved
@github-actions github-actions bot added the tests unit tests and docker configuration for tests label Aug 3, 2022
@mdouchin mdouchin self-requested a review August 9, 2022 08:14
mdouchin
mdouchin approved these changes Aug 9, 2022
View reviewed changes
Copy link
Collaborator

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Gustry Gustry merged commit 6a395f2 into 3liz:master Aug 9, 2022
@Gustry Gustry deleted the server_version branch August 9, 2022 08:16
@3liz-bot 3liz-bot mentioned this pull request Aug 9, 2022
Merged
@Gustry Gustry mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdouchin mdouchin mdouchin approved these changes

@nboisteault nboisteault Awaiting requested review from nboisteault

@nworr nworr Awaiting requested review from nworr

Assignees
No one assigned
Labels
administration pages tests unit tests and docker configuration for tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set the minimum Lizmap QGIS server version in the source code
2 participants
@Gustry @mdouchin