This repository has been archived by the owner on Mar 7, 2021. It is now read-only.
Improve/decimal separator based on locale #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zenangst would this cause any problems for you? |
|
@aminiz could you please clean up this whitespaces?
|
Change to use NSLocaleDecimalSeparator instead of “,” in FORMFloatInputValidator floatSet.
|
Sorry about that. Can you please take a look now. |
|
Might cause some issues, will have to investigate 🤔 |
|
@zenangst thanks! |
|
@zenangst Any update on this? Should I just merge? Tests are passing. |
|
@3lvis haven't checked but I think you can merge, if there are any issues I'll look into them later and post a fix. |
This was referenced May 11, 2016
|
Ships on https://github.com/hyperoslo/Form/releases/tag/3.10.1 Thanks @aminiz 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to use NSLocaleDecimalSeparator instead of
,inFORMFloatInputValidator floatSet.