Update memcached.js #276
Open
Update memcached.js #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
console.log('Invalid JSON data', e, dataSet);
dataSet = {};
| try{ | ||
| dataSet = JSON.parse(dataSet); | ||
| }catch(e){ | ||
| console.log('Invalid JSON data', e, dataSet); |
There was a problem hiding this comment.
I'm not a fan of using console.log to notify about errors. Libraries should avoid output to stdout/stderr imho. Other than that, try try/catch block is a good idea.
There was a problem hiding this comment.
Failing silently can cause lots of head-scratching for the users of the library too if something goes wrong...
Maybe passing a flag (like verbose=true or something like that) or a custom logger object (that can have the log level disabled) in the client constructor would be a more appropriate alternative?
There was a problem hiding this comment.
I would say emitting an error would be more appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.