Fix: enable multinamespaced mode for the webhook #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since now the bootstrap config for the envoy pods is generated by an init container, the webhook needs to inject the address of the discovery service in the Pod. To do so it inspects the DiscoveryService resources present in the Pod's namespace. This was failing for the multinamespaced OLM install mode as the code to manage this was missing from the webhook.
3scale-robot
added
kind/bug
3scale-robot
added
needs-size
|
/ok-to-test |
3scale-robot
added
the
ok-to-test
|
LGTM label has been added. Git tree hash: eb0f3bfcb06386fab3434d945257d6a3f25a65d8
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since now the bootstrap config for the envoy pods is generated by an
init container, the webhook needs to inject the address of the discovery
service in the Pod. To do so it inspects the DiscoveryService resources
present in the Pod's namespace. This was failing for the multinamespaced
OLM install mode as the code to manage this was missing from the
webhook.
/kind bug
/priority important-soon
/assign