Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make envoy 1.18.3 the default #105

Merged
merged 3 commits into from
Jun 1, 2021
Merged

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Jun 1, 2021

Some changes were required in the e2e tests to execute V2 API tests using older v.16, as it's the last Envoy version that supports that API.

/kind feature
/priority important-longterm
/assign

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. labels Jun 1, 2021
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/S Requires less than a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Jun 1, 2021
@roivaz
Copy link
Member Author

roivaz commented Jun 1, 2021

/ok-to-test

@3scale-robot 3scale-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 1, 2021
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2021
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fafdcc414a796f6cfa133e0fb55e5b1615eafb6c

@slopezz
Copy link
Member

slopezz commented Jun 1, 2021

/lgtm

@3scale-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@3scale-robot 3scale-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2021
@roivaz roivaz added lgtm Indicates that a PR is ready to be merged. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jun 1, 2021
@roivaz
Copy link
Member Author

roivaz commented Jun 1, 2021

Fixed a test that was broken due to the change of default image. Should be fixed for future changes also.

/ok-to-test

@3scale-robot 3scale-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 1, 2021
@roivaz
Copy link
Member Author

roivaz commented Jun 1, 2021

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2021
@3scale-robot 3scale-robot merged commit c0c35ec into main Jun 1, 2021
@3scale-robot 3scale-robot deleted the feat/default-to-envoy-1.18.3 branch June 1, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants