-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the built image as the default for Envoy init and shutdown #130
Conversation
While the Envoy init and shutdown manager images can be overridden at runtime, the defaults were more-or-less hardcoded. Now the default image is the same as what was built. This means that the init manager and shutdown manager images will respect build-time overrides of IMAGE_TAG_BASE, e.g., to use a different registry. NOTE: I wanted to query at runtime the image that the manager container is currently running, but that turns out to be difficult to do. The image name isn't available in the downstream API[1] so for now I'm doing a cut-n-paste of the existing "version" code and having the Makefile pass the image name into the generator. [1] kubernetes/kubernetes#19475
/kind feature |
This awesome @acnodal-tc! I actually needed to do something like this for some internal builds of the operator. I will expand it even further in an upcoming PR so the image can also be overridden in runtime using an environment variable in the operator Pod. Just one minor thing I spotted, could you also delete the |
/ok-to-test |
/priority important-soon |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
While the Envoy init and shutdown manager images can be overridden at
runtime, the defaults were more-or-less hardcoded. Now the default
image is the same as what was built. This means that the init manager
and shutdown manager images will respect build-time overrides of
IMAGE_TAG_BASE, e.g., to use a different registry.
NOTE: I wanted to query at runtime the image that the manager
container is currently running, but that turns out to be difficult to
do. The image name isn't available in the downstream API[1] so for now
I'm doing a cut-n-paste of the existing "version" code and having the
Makefile pass the image name into the generator.
[1] kubernetes/kubernetes#19475