Delete pod stats on pod deleted #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
kind/bug
3scale-robot
added
size/M
roivaz
commented
Oct 31, 2022
Comment on lines
13
to
41
| func (s *Stats) RunGC(client kubernetes.Interface, namespace string, stopCh <-chan struct{}) error { | ||
|
|
||
| factory := informers.NewSharedInformerFactoryWithOptions(client, time.Hour*24, informers.WithNamespace(namespace)) | ||
| podInformer := factory.Core().V1().Pods() | ||
| podInformer.Informer().AddEventHandler( | ||
| cache.ResourceEventHandlerFuncs{ | ||
| DeleteFunc: deleteStatsForDeletedPodsFn(s), | ||
| }, | ||
| ) | ||
|
|
||
| factory.Start(stopCh) | ||
| // wait for the initial synchronization of the local cache. | ||
| if !cache.WaitForCacheSync(stopCh, podInformer.Informer().HasSynced) { | ||
| return errors.New("failed to sync") | ||
| } | ||
|
|
||
| return nil | ||
|
|
||
| } | ||
|
|
||
| func deleteStatsForDeletedPodsFn(s *Stats) func(obj interface{}) { | ||
|
|
||
| return func(obj interface{}) { | ||
| switch o := obj.(type) { | ||
| case *corev1.Pod: | ||
| s.DeleteKeysByFilter(o.GetName()) | ||
| } | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
This is the relevant code that deletes the pod related stats when a pod is deleted.
|
/lgtm |
|
LGTM label has been added. Git tree hash: 66624cecbcedd5867bb20434503c03be7bc7651f
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
|
/ok-to-test |
3scale-robot
added
the
ok-to-test
roivaz
removed
the
approved
roivaz
force-pushed
the
fix/pod-stats-cleanup
branch
from
4c518f4
to
91c3e14
Compare
3scale-robot
added
approved
roivaz
added
ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a garbage collector to delete stats of pods that have been deleted. It is basically a k8s informer that reacts to pod deletion events by removing all the stats related to the pod from the stats cache.
The PR also removes all stats that had information about the grpc stream_id. This was previously used to cleanup stats but it was producing inconsistent results .
/kind bug
/priority important-soon
/assign