Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't restrict the types that can be unmarshalled #175

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Don't restrict the types that can be unmarshalled #175

merged 1 commit into from
Apr 3, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Apr 3, 2023

Make the unmarshal possible for any proto message, not just the top level ones. This is useful for when the serializer package is used form other project.

/kind feature
/priority important-longterm
/assign

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. labels Apr 3, 2023
@3scale-robot 3scale-robot added the needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. label Apr 3, 2023
@roivaz
Copy link
Member Author

roivaz commented Apr 3, 2023

/ok-to-test

@3scale-robot 3scale-robot added size/S Requires less than a day to complete the PR or the issue. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Apr 3, 2023
@raelga
Copy link
Contributor

raelga commented Apr 3, 2023

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b745b33434116907d5dde3cb5e7ebdeb390114f

@roivaz
Copy link
Member Author

roivaz commented Apr 3, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2023
@3scale-robot 3scale-robot merged commit 4009944 into main Apr 3, 2023
@3scale-robot 3scale-robot deleted the feat/unmarshall-anything branch April 3, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga Awaiting requested review from raelga

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@raelga raelga

@roivaz roivaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roivaz @raelga @3scale-robot