Fix rollout of the discovery service #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… versions running at the same time
3scale-robot
added
kind/bug
3scale-robot
added
size/S
slopezz
reviewed
May 25, 2023
|
/lgtm |
|
LGTM label has been added. Git tree hash: b56536786f6f5a7393b3ac1d70f243a272a0f680
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of health checks, the rollout of new versions of the discovery service is slower because the new pod takees some seconds to pass the health checks. This makes that both the old controllers and the new ones run in parallel for some seconds, trying to write to the same EnvoyConfigRevisions and causing problems. To fix this:
I have tested an upgrade from v0.11.1 to a version with the changes in this PR and it fixes the problems.
/kind bug
/priority critical-urgent
/assign
/ok-to-test