Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/gorutine-leak #201

Merged
merged 3 commits into from
Jun 14, 2023
Merged

fix/gorutine-leak #201

merged 3 commits into from
Jun 14, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Jun 14, 2023

The discovery service grpc health check was leaving open connections and causing a goroutine leak.

Also raise the context timeout for the discovery service healthz checks as it was too aggressive.

/kind bug
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/M Requires about a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Jun 14, 2023
@slopezz
Copy link
Member

slopezz commented Jun 14, 2023

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 28fb4578bce53eeda5b76f82ceb7df7ffbd85aab

@raelga
Copy link
Contributor

raelga commented Jun 14, 2023

/lgtm

@roivaz
Copy link
Member Author

roivaz commented Jun 14, 2023

/ok-to-test

@3scale-robot 3scale-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 14, 2023
@roivaz
Copy link
Member Author

roivaz commented Jun 14, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@3scale-robot 3scale-robot merged commit dc5d5b4 into main Jun 14, 2023
@3scale-robot 3scale-robot deleted the fix/gorutine-leak branch June 14, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga Awaiting requested review from raelga

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@raelga raelga

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roivaz @slopezz @3scale-robot @raelga