Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test certs #205

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Update test certs #205

merged 3 commits into from
Aug 8, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 4, 2023

This updates the unit test cert (which had expired), changes the unit tests so they share certs instead of each having their own, and has a janitorial commit to update the generated yaml files to match the makefile-specified controller-tools version.

/closes #204

@caboteria
Update generated yaml to refect new controller-gen version
520ea83 
The controller-gen tool evidently stamps the files it generates with
its version so when we upgrade controller-gen the generated yaml files
change, too.

Signed-off-by: Toby Cabot <toby@acnodal.io>
@caboteria
Share certificates in the unit tests
e3ccd64 
The generate and verify tests had their own certs but they can share
certs which will make it easier to renew when they expire.

Signed-off-by: Toby Cabot <toby@acnodal.io>
@caboteria
Renew the unit test certs
d48e59d 
They will be valid for 10 years.

Signed-off-by: Toby Cabot <toby@acnodal.io>
@3scale-robot 3scale-robot added needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/M Requires about a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Aug 4, 2023
@ghost
Copy link
Author

ghost commented Aug 4, 2023

/kind bug

@3scale-robot 3scale-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. labels Aug 4, 2023
@ghost ghost closed this Aug 4, 2023
@ghost ghost deleted the update-test-certs branch August 4, 2023 20:43
@ghost ghost restored the update-test-certs branch August 4, 2023 20:44
@ghost ghost reopened this Aug 7, 2023
@ghost
Copy link
Author

ghost commented Aug 7, 2023

Sorry for closing and reopening, I guess I had a git brainfart.

@ghost
Copy link
Author

ghost commented Aug 7, 2023

/priority high

Seems like high priority is justified since the build is broken.

@3scale-robot
Copy link
Contributor

@acnodal-tc: The label(s) priority/high cannot be applied, because the repository doesn't have them.

In response to this:

/priority high

Seems like high priority is justified since the build is broken.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link
Author

ghost commented Aug 7, 2023

/priority important-soon

@3scale-robot 3scale-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. and removed needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. labels Aug 7, 2023
@roivaz roivaz self-assigned this Aug 8, 2023
@roivaz
Copy link
Member

roivaz commented Aug 8, 2023

/ok-to-test

@3scale-robot 3scale-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 8, 2023
@roivaz
Copy link
Member

roivaz commented Aug 8, 2023

/lgtm
/approve

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1c3fa893eee20ee8cf3ac96a05855947d0317ab2

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@3scale-robot 3scale-robot merged commit f310678 into 3scale-ops:main Aug 8, 2023
9 checks passed
@ghost ghost deleted the update-test-certs branch August 12, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga Awaiting requested review from raelga

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@roivaz roivaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit test failure - expired cert?
3 participants
@3scale-robot @roivaz @caboteria