Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade/libs #217

Merged
merged 10 commits into from
Feb 8, 2024
Merged

Upgrade/libs #217

merged 10 commits into from
Feb 8, 2024

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Feb 5, 2024 •
edited
Loading

/kind feature
/priority important-soon
/assign

@3scale-robot 3scale-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 5, 2024
@3scale-robot 3scale-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. label Feb 5, 2024
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/XL Requires about a week to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Feb 5, 2024
@roivaz roivaz mentioned this pull request Feb 5, 2024
Closed
@3scale-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 034dfb548e117c560575aa8589c4f94cded2509a

@roivaz
Copy link
Member Author

roivaz commented Feb 8, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@3scale-robot 3scale-robot merged commit d001b4a into main Feb 8, 2024
4 checks passed
@3scale-robot 3scale-robot deleted the upgrade/libs branch February 8, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slopezz slopezz slopezz approved these changes

@raelga raelga Awaiting requested review from raelga

Assignees

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-commit-message kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/XL Requires about a week to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Incorrect conversion between integer types
3 participants
@roivaz @3scale-robot @slopezz