Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/upgrade-kubebuilder-v3 #78

Merged
merged 15 commits into from
Mar 22, 2021
Merged

feat/upgrade-kubebuilder-v3 #78

merged 15 commits into from
Mar 22, 2021

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Mar 19, 2021

  • Upgrade project to kubebuilder v3 and operator-sdk 1.5
  • Fixes some inconcistencies in the API definitions where some optional fields were not defined as pointers as they should
  • Upgrades the crd API to v1
  • Upgrades the mutating webhook to v1
  • Adds probes both for the operator and the webhook
  • Renames some paths so controller and api packages are where the kubebuilder CLI expects them to be

Closes #76 #45

@roivaz roivaz requested review from raelga and slopezz March 19, 2021 12:22
@roivaz roivaz self-assigned this Mar 19, 2021
slopezz
slopezz previously approved these changes Mar 19, 2021
@slopezz
Copy link
Member

slopezz commented Mar 19, 2021

@roivaz I have approved the PR, but bear in mind that it seems you need to rebase

slopezz
slopezz previously approved these changes Mar 22, 2021
There seems to be a problem with 0.8.0 in openshift 4.6 and 4.7 where
the rabc-proxy fails to start. Reverting to 0.5.0 while this issue is
analyzed. Check
operator-framework/operator-sdk#4684 for more
details.

This reverts commit 6c4c763.
@roivaz roivaz merged commit 1fa386f into master Mar 22, 2021
@roivaz roivaz deleted the feat/upgrade-kubebuilder-v3 branch March 22, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to kubebuilder v3
2 participants