feat/envoy-deployment #89

roivaz · 2021-04-12T11:26:15Z

This PR adds a new custom resource, the EnvoyDeployment that allows to deploy envoy as a k8s Deployment.

Implemented functionality for EnvoyDeployment:

Requires a reference to a DiscoveryService and to an EnvoyConfig to be able to configure itself through service discovery. Will dynamically load the envoy resources specified in the EnvoyConfig.
Automatically generates the required bootstrap configuration to talk to the discovery service by using the provided reference.
Automatically selects the envoy API version at use by using the provided reference to an EnvoyConfig resource.
Cofigurable number of replicas, either via a static number or using an HPA
Configurable Pod resource requirementes
Configurable Pod affinity
Configurable pod disruption budget
Configurable Pod image
Configurable Pod ports
Configurable extra arguments to pass to the envoy process
Configurable admin port and admin log path
Configurable liveness and readiness probe timeouts and thresholds
Automatically triggers rollouts when changes to envoy static configs (like admin port configurations) occur.

An example of the resource:

apiVersion: operator.marin3r.3scale.net/v1alpha1
kind: EnvoyDeployment
metadata:
  name: envoy
spec:
  discoveryServiceRef: xds
  envoyConfigRef: config
  image: envoyproxy/envoy:1.16.2
  ports:
    - name: https
      port: 8443
  extraArgs:
    - --component-log-level
    - http:debug
  adminAccessLogPath: /dev/null
  resources:
    requests:
      memory: "64Mi"
      cpu: "100m"
    limits:
      memory: "128Mi"
      cpu: "200"
  replicas:
    dynamic:
      minReplicas: 1
      maxReplicas: 10
      metrics:
        - type: Resource
          resource:
            name: cpu
            target:
              type: Utilization
              averageUtilization: 50
  podDisruptionBudget:
    minAvailable: 1

Integration and e2e tests have been added to cover the added functinality.

… package (envoy/bootstrap/defaults)

…yment

…discovery. This change strives for simplicity

…rap resource

The condition to update the resource wsa wrong and the controller was never picking up changes and properly updating the configmaps with the config.

* Configurable HPA * Configurable Pod affinity * Configurable PDB

…es.go

…or the moment

roivaz · 2021-04-12T13:13:26Z

/ok-to-test

slopezz · 2021-04-12T14:09:46Z

/lgtm

raelga · 2021-04-12T14:57:32Z

Awesome work @roivaz , congrats!
/lgtm

3scale-robot · 2021-04-12T15:16:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roivaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roivaz · 2021-04-12T15:37:51Z

/ok-to-test

raelga · 2021-04-13T07:54:49Z

/lgtm

roivaz added 30 commits March 30, 2021 12:25

Scaffold operator.marin3r.3scale.net/EnvoyDeployment api

20e46b6

Basic implementation of api and controller, without any specific logic

2eb80c2

Move default values for envoy containers/volumes/files to a dedicated…

5ef7c73

… package (envoy/bootstrap/defaults)

Start writting the resource generators

6bbbca8

Fix permissions and generate CRD

1932ceb

Fix properties incorrectly set as pointers in EnvoyBootstrap resource

21de302

Completed first implementation of resources generation for EnvoyDeplo…

c08e56c

…yment

Implement the EnvoyDeployment controller

2c51a87

Add EnvoyDeployment sample

c0524aa

Rename example

dc3fd01

Add new example for the EnvoyDeployment resource

9db3bea

Add missing code marker in EnvoyDeployment spec definition

218bea7

Use same suite setup for all e2e test suites

730411a

Add e2e tests for the EnvoyDeployment resource

1d404e5

Let the user specify the DiscoveryService name instead of trying auto…

e8bca0f

…discovery. This change strives for simplicity

Add missing error handling in discoveryservice controller

8762ce5

Generate reconcile requests fo EnvoyDeployments on EnvoyConfig events

062fc60

Add the hash of the bootstrap config to the status of the EnvoyBootst…

bbefc54

…rap resource

Fix a bug in the EnvoyBootstrap resource

18e47fb

The condition to update the resource wsa wrong and the controller was never picking up changes and properly updating the configmaps with the config.

Make admin port and admin access log configurable

ff85c3d

Rename EnvoyDeployment Deployment as marin3r-envoydeployment-<name>

c357b54

Add integration tests for EnvoyDeployment

8c74fb9

Update example

41a38db

Add the admin port to the list of container ports

5903998

Fix timeout in e2e test

f5b7f99

Fix e2e EnvoyDeployment tests

63a1ce0

Add reliability for the envoy Deployment

29c5973

* Configurable HPA * Configurable Pod affinity * Configurable PDB

Add unit tests for apis/operator.marin3r/v1alpha1/envoydeployment_typ…

5be8bc7

…es.go

Remove TODO comment, autodiscovery of ports will not be implemented f…

cd6fb1f

…or the moment

Fix missing api from PROJECT file

1ec5174

roivaz added 2 commits April 12, 2021 12:59

Remove namespace form examples/e2e/deployment

40439f1

Prepare v0.8.0-alpha1

6567126

roivaz added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 12, 2021

roivaz requested review from raelga and slopezz April 12, 2021 11:26

3scale-robot added needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Apr 12, 2021

roivaz added the size/XL Requires about a week to complete the PR or the issue. label Apr 12, 2021

3scale-robot removed the needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. label Apr 12, 2021

roivaz added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. label Apr 12, 2021

3scale-robot removed the needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. label Apr 12, 2021

3scale-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 12, 2021

3scale-robot assigned slopezz Apr 12, 2021

3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2021

3scale-robot assigned raelga Apr 12, 2021

Fix lockedresources.NewFromManager function

e12f1a5

3scale-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2021

3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021

roivaz removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 12, 2021

3scale-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 12, 2021

3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2021

3scale-robot merged commit 9e9a5d2 into main Apr 13, 2021

3scale-robot deleted the feat/envoy-deployment branch April 13, 2021 07:56

roivaz mentioned this pull request Jun 15, 2021

Deploy envoy as a standalone Deployment #10

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/envoy-deployment #89

feat/envoy-deployment #89

roivaz commented Apr 12, 2021 •

edited

Loading

roivaz commented Apr 12, 2021

slopezz commented Apr 12, 2021

raelga commented Apr 12, 2021

3scale-robot commented Apr 12, 2021

roivaz commented Apr 12, 2021

raelga commented Apr 13, 2021

feat/envoy-deployment #89

feat/envoy-deployment #89

Conversation

roivaz commented Apr 12, 2021 • edited Loading

roivaz commented Apr 12, 2021

slopezz commented Apr 12, 2021

raelga commented Apr 12, 2021

3scale-robot commented Apr 12, 2021

roivaz commented Apr 12, 2021

raelga commented Apr 13, 2021

roivaz commented Apr 12, 2021 •

edited

Loading