Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Add redis sentinel dashboard #197

Merged
merged 5 commits into from
May 5, 2022
Merged

Conversation

slopezz
Copy link
Member

@slopezz slopezz commented May 5, 2022

Related to #196

  • Adds a whole new redis sentinel grafana dashboard
  • Adds sentinel controller suite testing (was one of the few controllers without testing)
  • Updates a sentinel sdwon label (from server to redis_server), to be consistent with the rest of sentinel metrics
  • Redis sentinel ashboard can be checked at staging

image
image

There are a couple of issues/bugs that will be opened soon with details:

  • One related to most important counters whose default value is null, making the usage of needed rate to detect changes on a counter not usable for the first event since the operator runs (initial reported value should be always 0)
  • One related to the role label, for every change on a role for a redis_server a new timeserver is created (OK), but the old timeseriesDB keeps being reported ad infinitum with latest retrieved value, instead of stop reporting the not existing metric, making the coexisting of lots of metrics which dont exists anymore

/kind feature
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/XL Requires about a week to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels May 5, 2022
@3scale-robot 3scale-robot requested review from raelga and roivaz May 5, 2022 11:42
@raelga
Copy link
Contributor

raelga commented May 5, 2022

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2022
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4e0890d7b1ff3338aaedd2a4483ee1e785d8f42c

@slopezz
Copy link
Member Author

slopezz commented May 5, 2022

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@3scale-robot 3scale-robot merged commit 2d3b94f into main May 5, 2022
@3scale-robot 3scale-robot deleted the feat/sentinel-dashboard branch May 5, 2022 14:07
3scale-robot added a commit that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/XL Requires about a week to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants