-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Add HA to backend controller #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…marin3r port without proxy-protocol enabled
slopezz
force-pushed
the
feature/add-ha-backend
branch
from
July 27, 2020 14:53
27fd368
to
c2a5ccc
Compare
raelga
approved these changes
Jul 28, 2020
roivaz
requested changes
Jul 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor typo needs fixing. Goog job!
slopezz
force-pushed
the
feature/add-ha-backend
branch
from
July 28, 2020 08:26
3aa6d85
to
74007b2
Compare
roivaz
approved these changes
Jul 28, 2020
This was referenced Jul 28, 2020
raelga
added
kind/feature
Categorizes issue or PR as related to a new feature.
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple sprints to complete.
size/M
Requires about a day to complete the PR or the issue.
labels
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple sprints to complete.
size/M
Requires about a day to complete the PR or the issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
PodDisruptionBudget
for backend-worker and backend-listenerpresent
)maxUnavailable:1
number
or apercentage
(both cases tested and working)minAvailable
instead of defaultmaxUnavailable
:minAvailable
(ignoring defaultmaxUnavailable
)maxUnavailable
, operator task managing PDB will fail, because ansible operator executed patch operation, and these 2 vars are mutually exclusive and cannot coexists on same PDBminAvailable
and want to usemaxUnavailable
HoritzontalPodAutoscaler
for backend-worker and backend-listenerpresent
)minReplicas:2
maxReplicas:4
resourceName:cpu
(onlycpu/memory
admitted at CRD level)resourceUtilization:90
(a percentage)true
, thenreplicas
CR field is ignored, not managed by DeploymentspodAntiffinity
for backend-worker and backend-listener following best practices:podAntiffinity
(usingPreferred
instead ofRequired
)PodAntiffinity tests
Regarding
podAntiffinity
, I have done several testing to ensure it is working as expected.So this is the worker nodes, 2 per AZ:
Evolution history of AZs used by each deployment depending on number of replicas
Listener:
Worker: