Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New go based controllers: apicast, mapping-service, autossl #57

Merged
merged 20 commits into from
Jan 27, 2021
Merged

New go based controllers: apicast, mapping-service, autossl #57

merged 20 commits into from
Jan 27, 2021

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Jan 22, 2021 •
edited by slopezz
Loading

Related to #55

@roivaz roivaz added kind/feature Categorizes issue or PR as related to a new feature. size/XXL Requires more than a week to complete the PR or the issue. labels Jan 22, 2021
@roivaz roivaz requested review from raelga and slopezz January 22, 2021 12:46
slopezz
slopezz reviewed Jan 26, 2021
View reviewed changes
Copy link
Member

@slopezz slopezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change from ansible to go!

Can you please check my comments?

bundle/manifests/saas-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
config/samples/saas_v1alpha1_mappingservice.yaml Outdated Show resolved Hide resolved
config/samples/saas_v1alpha1_apicast.yaml Outdated Show resolved Hide resolved
pkg/generators/mappingservice/deployment.go Outdated Show resolved Hide resolved
pkg/generators/autossl/deployment.go Show resolved Hide resolved
pkg/generators/autossl/deployment.go Outdated Show resolved Hide resolved
api/v1alpha1/common_types.go Outdated Show resolved Hide resolved
@roivaz
Copy link
Member Author

roivaz commented Jan 26, 2021

@slopezz I think that all discussions can be resolved now. Please take a look!

slopezz
slopezz approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@slopezz slopezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying my suggestions! 😃

@raelga I know you were waiting for my review, now it is your turn, I have possibly missed something 😝

@roivaz @slopezz
Fix typo
ad003aa 
Co-authored-by: Sergio López <41513123+slopezz@users.noreply.github.com>
@roivaz roivaz mentioned this pull request Jan 27, 2021
Merged
raelga
raelga approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@roivaz roivaz merged commit f31d167 into feat/go Jan 27, 2021
@roivaz roivaz deleted the v0.9.0 branch January 27, 2021 12:40
@slopezz slopezz mentioned this pull request Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slopezz slopezz slopezz approved these changes

@raelga raelga raelga approved these changes

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XXL Requires more than a week to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roivaz @raelga @slopezz