-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wildcard router from operator and templates #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsorianod
force-pushed
the
operator-remove-wildcard-router
branch
from
May 31, 2019 16:25
50cac8d
to
25229b3
Compare
I tested to deploy the operator without the WildcardRouter and it seems to work (creating the needed additional routes when creating a service and/or a tenant) |
miguelsorianod
force-pushed
the
operator-remove-wildcard-router
branch
from
June 3, 2019 09:45
25229b3
to
8a45ac0
Compare
miguelsorianod
force-pushed
the
operator-remove-wildcard-router
branch
from
June 11, 2019 13:12
74a84ed
to
22c7144
Compare
miguelsorianod
changed the title
[WIP] Operator remove wildcard router
[WIP] remove wildcard router from operator and templates
Jun 11, 2019
miguelsorianod
changed the title
[WIP] remove wildcard router from operator and templates
[WIP] Remove wildcard router from operator and templates
Jun 11, 2019
Merged
In OpenShift 4.1 wildcardRoutes are not supported so we remove all the elements related to WildcardRouter in the operator.
To allow using ampimages without wildcardrouter we decoupled the wildcardrouter imagestream from the ampimages component.
This generation only moved some elements of position in the templates, making the observed changes in this commit.
Removing WildcardRouter makes the original tests fail because WildcardRoute does not exist anymore. Probably we'll be able to add it when Zync replacement functionality is merged.
miguelsorianod
force-pushed
the
operator-remove-wildcard-router
branch
from
June 12, 2019 15:57
eaf6c48
to
042d3c2
Compare
Code Climate has analyzed commit 042d3c2 and detected 12 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
miguelsorianod
changed the title
[WIP] Remove wildcard router from operator and templates
Remove wildcard router from operator and templates
Jun 12, 2019
eguzki
approved these changes
Jun 12, 2019
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the WildcardRouter on the operator and templates side.
Making this change implies: