Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wildcard router from operator and templates #135

Merged
merged 9 commits into from
Jun 12, 2019

Conversation

miguelsorianod
Copy link
Contributor

@miguelsorianod miguelsorianod commented May 31, 2019

This PR removes the WildcardRouter on the operator and templates side.

Making this change implies:

  • We are no longer using WildcardRouter in the operator
  • With this change, even deploying the productVersion 2.5 with the operator does NOT include the WildcardRouter. We could still deploy it with the wildcardRouter by using the 2.5-stable branch that won't have this modification.
  • The idea for the 2.6 release is to remove the productVersion "2.5" and only allow to use the productVersion value "2.6" (or an equivalent mechanism that only provides the 2.6 images).
  • From 2.6 release onwards we won't have WildcardRouter functionality with the operator, even when manually deployed in OpenShift 3.11. Manual route creation will be needed to add new tenants or we should provide another mechanism to automate it
  • We won't have WildcardRouter in templates either because the new release of Zync includes code to manage the routes to replace it. This means we'll need to provide some migration procedure for it in OpenShift 3.11 when upgrading from 2.5 to 2.6

@miguelsorianod
Copy link
Contributor Author

I tested to deploy the operator without the WildcardRouter and it seems to work (creating the needed additional routes when creating a service and/or a tenant)

@miguelsorianod miguelsorianod force-pushed the operator-remove-wildcard-router branch from 25229b3 to 8a45ac0 Compare June 3, 2019 09:45
@miguelsorianod miguelsorianod force-pushed the operator-remove-wildcard-router branch from 74a84ed to 22c7144 Compare June 11, 2019 13:12
@miguelsorianod miguelsorianod changed the title [WIP] Operator remove wildcard router [WIP] remove wildcard router from operator and templates Jun 11, 2019
@miguelsorianod miguelsorianod changed the title [WIP] remove wildcard router from operator and templates [WIP] Remove wildcard router from operator and templates Jun 11, 2019
@miguelsorianod miguelsorianod mentioned this pull request Jun 12, 2019
In OpenShift 4.1 wildcardRoutes are not supported so
we remove all the elements related to WildcardRouter in the
operator.
To allow using ampimages without wildcardrouter we decoupled
the wildcardrouter imagestream from the ampimages component.
This generation only moved some elements of position in the
templates, making the observed changes in this commit.
Removing WildcardRouter makes the original tests fail because
WildcardRoute does not exist anymore. Probably we'll be able to
add it when Zync replacement functionality is merged.
@miguelsorianod miguelsorianod force-pushed the operator-remove-wildcard-router branch from eaf6c48 to 042d3c2 Compare June 12, 2019 15:57
@codeclimate
Copy link

codeclimate bot commented Jun 12, 2019

Code Climate has analyzed commit 042d3c2 and detected 12 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 12

View more on Code Climate.

@miguelsorianod miguelsorianod changed the title [WIP] Remove wildcard router from operator and templates Remove wildcard router from operator and templates Jun 12, 2019
@eguzki eguzki merged commit a92349c into master Jun 12, 2019
@eguzki eguzki deleted the operator-remove-wildcard-router branch June 12, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants