-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activedocs CRUD operations #145
Conversation
Added ActiveDocs Entity |
0294b52
to
637c8f5
Compare
9aec7da
to
421a261
Compare
I've updated the PR to add:
|
2c4b5f5
to
2e365e5
Compare
The create command usage is:
For the moment I've not implemented the 'apply' command because I've not found a suitable format for the command:
|
I think |
77dd599
to
a5449a8
Compare
Implemented apply and added integration tests. I think this should be finished. @eguzki could you review it? Thank you. |
Toolbox will figure it out. | ||
* Update to `published=true` activedocs by `--publish` flag. | ||
* Update to `published=false` method by `--hide` flag. | ||
* *The `--openapi-spec` flag is mandatory when the specified activedocs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not a flag, but optional parameter
DESCRIPTION | ||
List all defined ActiveDocs | ||
|
||
OPTIONS FOR ACTIVEDOCS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be useful --service
to list only activedocs for a certain service. But let's users demand first
include_context :random_name | ||
include_context :resources | ||
subject { ThreeScaleToolbox::CLI.run(command_line_str.split) } | ||
let(:remote) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let(:remote) { client_url }
should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
a5449a8
to
a40237e
Compare
Applied requested changes |
Fixes #125