-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] Enable squash merging on repo #151
Comments
You do not need that to improve your PR. You can do it using git. You'll need to become familiar with terms such as |
I know, but I tend to mess it up which is why I thought it would be nice and easier if we could just enable that option on the repo ;) |
As I understood, this feature does squashing only at the moment of doing a merge. But I think it indeed would be useful to rebase the branch before that, before making the branch ready for review, to make it easier for the reviewer. |
rebasing to make sure the delta is the real delta versus head of master - absolutely. But different thing from squashing to combine commits and make cleaner, no? |
Sorry, we are not going to enable the squash merging, please rebase your branch correctly before merge (with one or more commits as needed) |
Can the repo administrator enable squash merging on repo as per this article? Not sure I like how #150 is currently looking :)
The text was updated successfully, but these errors were encountered: