[resty.resolver] try to resolve upstream peers #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
resolver-upstream
branch
2 times, most recently
from
fd388cf
to
437a25c
Compare
mikz
force-pushed
the
resolver-upstream
branch
from
437a25c
to
5a28886
Compare
davidor
reviewed
Nov 15, 2017
apicast/src/resty/resolver.lua
Outdated
| return nil, err | ||
| end | ||
|
|
||
| for i=1, #peers do |
There was a problem hiding this comment.
According to the if above, here we could have peers = nil, and then #peers would raise an error.
There was a problem hiding this comment.
True that is possible. Will change the condition to return when there are no peers.
mikz
force-pushed
the
resolver-upstream
branch
2 times, most recently
from
eb4727f
to
f558e4f
Compare
* defining an upstream can be used as a shortcut to skip DNS resolution * if an upstream is defined with the same name then use the peers
mikz
force-pushed
the
resolver-upstream
branch
from
f558e4f
to
5b7d9e5
Compare
davidor
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #474