[THREESCALE-630] passthrough invalid HTTP headers #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* no need to print `\r` or the body when there isn't any
davidor
reviewed
Feb 20, 2018
gateway/conf/nginx.conf.liquid
Outdated
| @@ -41,6 +41,9 @@ http { | |||
| lua_package_path "{{ lua_path | default: package.path }}"; | |||
| lua_package_cpath "{{ lua_cpath | default: package.cpath }}"; | |||
|
|
|||
| underscores_in_headers on; | |||
There was a problem hiding this comment.
Is this needed if ignore_invalid_headers is set to off?
From the docs:
When the use of underscores is disabled, request header fields whose names contain underscores are marked as invalid and become subject to the ignore_invalid_headers directive.
davidor
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIcast should not drop any headers and just pass them to upstream. Fixes https://issues.jboss.org/browse/THREESCALE-630.