Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require 'ljsonschema' only when the validation of schemas is enabled #660

Merged
merged 2 commits into from
Mar 20, 2018

Conversation

davidor
Copy link
Contributor

@davidor davidor commented Mar 20, 2018

The validation is enabled only in testing and the validator relies on a rock that is marked as a 'testing' dependency. That means we need to require the validator only when the option is enabled, otherwise, it will
crash because of a missing dependency.

The validation is enabled only in testing and the validator relies on a
rock that is marked as a 'testing' dependency. That means we need to
require the validator only when the option is enabled, otherwise it will
crash because of a missing dependency.
@davidor davidor requested a review from mikz March 20, 2018 11:17
Copy link
Contributor

@mikz mikz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidor davidor merged commit 820e942 into master Mar 20, 2018
@davidor davidor deleted the require-ljsonschema-only-when-needed branch March 20, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants