Retry auths when using the "resty" http ng backend #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
reviewed
Nov 28, 2018
mikz
approved these changes
Nov 28, 2018
davidor
force-pushed
the
retry-auths-when-error-closed
branch
from
6de17cb
to
46e1048
Compare
|
Rebased and fixed the changelog conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a change in the backend client module to retry authorizations when backend closes the connection and the client uses the resty implementation.
While testing the 3scale batcher policy, I got very sporadic errors because the authorization call to the 3scale backend failed. In those cases, APIcast was sending an auth request after backend closed the keep-alive connection because of a timeout. In those cases, when using the "resty" backend of the http client, the response has status = 0 and error = "closed". Authorizes are idempotent, so they can be retried safely in those cases.