Extract the main APIcast nginx configuration into own file #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mikz
force-pushed
the
template-main-nginx-config
branch
2 times, most recently
from
ae2996a
to
65db3f5
Compare
davidor
reviewed
Dec 3, 2018
mikz
force-pushed
the
template-main-nginx-config
branch
from
65db3f5
to
957d1c0
Compare
|
I'll also add unit tests for the template renderer and environment file to verify the context feature. |
mikz
force-pushed
the
template-main-nginx-config
branch
2 times, most recently
from
69eae39
to
627a911
Compare
davidor
reviewed
Dec 10, 2018
davidor
reviewed
Dec 10, 2018
davidor
reviewed
Dec 10, 2018
mikz
force-pushed
the
template-main-nginx-config
branch
from
627a911
to
7d77d96
Compare
mikz
force-pushed
the
template-main-nginx-config
branch
from
7457a43
to
0d20656
Compare
davidor
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having all APIcast specific configuration in one file included by liquid allows us to replace that file with different server blocks etc. For example that is used by the standalone mode: #926.
Depends on #963.