Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PF4 styles for settings page #1402

Conversation

damianpm
Copy link
Contributor

@damianpm damianpm commented Nov 6, 2019

What this PR does / why we need it:
The new integration settings component #1315 is missing PF4 styles.
Since #1019 we should import explicitly all PF4 styles required. This was a recommendation from PF4 team: https://github.com/patternfly/patternfly-react-seed/wiki/Disable-Patternfly-React-Auto-Style-Injection.

Which issue(s) this PR fixes

https://issues.jboss.org/browse/THREESCALE-3563

Verification steps

run bundle exec rake webpack:compile && bundle exec rake assets:precompile

Special notes for your reviewer:
Apply this patch to make it work:

diff --git a/app/javascript/packs/settings.js b/app/javascript/packs/settings.js
index e9bb1a69..0bfeb4b6 100644
--- a/app/javascript/packs/settings.js
+++ b/app/javascript/packs/settings.js
@@ -1,5 +1,5 @@
-import { initialize as authenticationWidget } from 'Settings/authentication-widget'
+import { initSettings as settingsWidgets } from 'Settings/index'

 document.addEventListener('DOMContentLoaded', () => {
-  authenticationWidget()
+  settingsWidgets({elementId: 'settings'})
 })

@damianpm damianpm force-pushed the THREESCALE-3563/include-PF4-styles branch 3 times, most recently from d80bd9c to 76c6318 Compare November 6, 2019 10:26
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #1402 into THREESCALE-3563/integration-settings will increase coverage by 16.86%.
The diff coverage is n/a.

Impacted file tree graph

@@                            Coverage Diff                            @@
##           THREESCALE-3563/integration-settings    #1402       +/-   ##
=========================================================================
+ Coverage                                 75.95%   92.81%   +16.86%     
=========================================================================
  Files                                      1799     2443      +644     
  Lines                                     51196    80397    +29201     
=========================================================================
+ Hits                                      38886    74622    +35736     
+ Misses                                    12310     5775     -6535
Impacted Files Coverage Δ
...sks/data_migration/fix_backend_config_path_test.rb 100% <0%> (ø) ⬆️
test/unit/tasks/swagger_test.rb 100% <0%> (ø) ⬆️
test/unit/tasks/sidekiq_test.rb 100% <0%> (ø) ⬆️
test/unit/stats/base_test.rb 100% <0%> (ø) ⬆️
test/unit/tasks/impersonation_admin_user_test.rb 100% <0%> (ø) ⬆️
test/unit/tasks/forum/migrate_forum_test.rb 100% <0%> (ø) ⬆️
test/unit/tasks/cms/cms_test.rb 100% <0%> (ø) ⬆️
spec/acceptance/api/feature_spec.rb
...n/user/notification_preferences_controller_test.rb 100% <0%> (ø)
...st/workers/delete_account_hierarchy_worker_test.rb 100% <0%> (ø)
... and 1364 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 441075d...05220ea. Read the comment docs.

@damianpm damianpm marked this pull request as ready for review November 6, 2019 10:33
@damianpm damianpm force-pushed the THREESCALE-3563/include-PF4-styles branch from 76c6318 to af4ca78 Compare November 6, 2019 10:52
@didierofrivia didierofrivia force-pushed the THREESCALE-3563/integration-settings branch from a850df1 to 441075d Compare November 18, 2019 14:45
@damianpm damianpm force-pushed the THREESCALE-3563/include-PF4-styles branch from af4ca78 to 05220ea Compare November 18, 2019 14:50
@didierofrivia didierofrivia merged this pull request into THREESCALE-3563/integration-settings Nov 18, 2019
@didierofrivia didierofrivia deleted the THREESCALE-3563/include-PF4-styles branch November 18, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants